Skip to content

Conversation

masatake
Copy link
Member

@masatake masatake commented Jun 12, 2025

I should pull this request into two.

<Edited in Fri Sep 26 07:12:52 PM JST 2025>
I don't understand the original comment that I wrote.
I'll explain the intent of this pull request.

With this change, ctags can extract bindir in

config_data = configuration_data({
  'bindir': get_option('prefix') / get_option('bindir'),

The following lines were in the original comment.
</Edited in Fri Sep 26 07:12:52 PM JST 2025>

(
This random should be removed from here:

input : "\n" L3781
match :'\n'            main[ 0] / ^([a-zA-Z_][a-zA-Z_0-9]*)[ \t\n]*=([^=]|$)/
match :'\n'            main[ 1] / ^project[ \t\n]*\\([ \t\n]*'([^']*[^\\\\])'[ \t\n]*/
match :'\n'            main[ 2] / ^subdir[ \t\n]*\\([ \t\n]*'([^']*[^\\\\])'[ \t\n]*/
match :'\n'            main[ 3] / ^test[ \t\n]*\\([ \t\n]*'([^']*[^\\\\])'[ \t\n]*/
match :'\n'            main[ 4] / ^[ \t\n]+/

...                   TABLE[ N] ...
result: matched 1 bytes
scope : 
action: NOP in {main}, stack: /

It would be helpful for optimization if ctags could report per-TABLE statistics (average N, s.d. N, max N).
)

Copy link

codecov bot commented Jun 12, 2025

Codecov Report

❌ Patch coverage is 0% with 65 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.87%. Comparing base (d80d5de) to head (8511130).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
optlib/meson.c 0.00% 65 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4275      +/-   ##
==========================================
- Coverage   85.94%   85.87%   -0.08%     
==========================================
  Files         248      248              
  Lines       63539    63593      +54     
==========================================
  Hits        54608    54608              
- Misses       8931     8985      +54     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@masatake
Copy link
Member Author

Surprisingly, per-table statistics were already implemented: --totals=extra.

@masatake masatake force-pushed the meson--cfgdata-inline-cfgvars branch from bcbc81d to 0b59a0e Compare September 26, 2025 01:39
  Before:
  $ time ./ctags -o -  /home/yamato/backup/var/util-linux/util-linux-2.41.devel-232-07aac-dirty/meson.build > /dev/null 2> /tmp/logf
  0.46s user 0.01s system 97% cpu 0.483 total

  After:
  0.19s user 0.01s system 97% cpu 0.209 total

Signed-off-by: Masatake YAMATO <[email protected]>
@masatake masatake force-pushed the meson--cfgdata-inline-cfgvars branch from 0b59a0e to 8511130 Compare September 26, 2025 01:44
@masatake masatake marked this pull request as ready for review September 26, 2025 04:54
@masatake masatake merged commit 241dfc3 into universal-ctags:master Sep 26, 2025
92 of 95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant