DX-1811: workflow endpoint feature set #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CahidArda
force-pushed
the
DX-1811-workflow-endpoint-feature-set
branch
from
8fe0f1d to
f2af66f
Compare
CahidArda
changed the title
in #118, we bumped express to express 5 which is a breaking change. One thing we missed was how the catch all routes were defined. Because of this, we were getting 'TypeError: Missing parameter name at 1: https://git.new/pathToRegexpError' errors in express example. Fixed it by updating the catch all routes in express handler. See the related issue for more details: expressjs/express#5936
alitariksahin
approved these changes
Aug 4, 2025
alitariksahin
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
WF_DetectTriggerfeature set which will cause workflow requests made to a non-workflow endpoint. We also return[WORKFLOW_PROTOCOL_VERSION_HEADER]: WORKFLOW_PROTOCOL_VERSIONin our responses fromserveso that theTodo: