Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions service_template/.devcontainer/devcontainer.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
"runArgs": [
"--cap-add=SYS_PTRACE",
"--security-opt",
"seccomp=unconfined"
"seccomp=unconfined",
"--network=host"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? exposing devcontainer to the network is dangerous

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The devсontainer is usefull because it helps quickly start developing without worrying about unnecessary configuration. The --network=host helps to avoid setting up common network names for the different containers running on the same computer. I see, this is a "dirty" practice. May be this should be specifically mentioned in a documentation?

],
"forwardPorts": [
8080
Expand All @@ -24,7 +25,9 @@
"ms-vscode.cmake-tools",
"ms-vscode.makefile-tools",
"vadimcn.vscode-lldb",
"ms-azuretools.vscode-docker"
"ms-azuretools.vscode-docker",
"ms-vscode.cpptools",
"ms-vscode.cpptools-extension-pack"
],
"settings": {
"cmake.automaticReconfigure": false,
Expand Down