Skip to content

Conversation

@maximenoel8
Copy link
Contributor

@maximenoel8 maximenoel8 commented Oct 20, 2025

What does this PR change?

Add support to terminal and build host sles15sp6 in controller

Issue(s):

@maximenoel8 maximenoel8 requested a review from a team as a code owner October 20, 2025 23:56
Copy link
Member

@srbarrios srbarrios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But maybe you can take the opportunity and add sp7 too.

@maximenoel8 maximenoel8 self-assigned this Nov 5, 2025
@Bischoff Bischoff self-requested a review November 5, 2025 12:19
Copy link
Contributor

@Bischoff Bischoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See remark

sle12sp5_buildhost = length(var.sle12sp5_buildhost_configuration["hostnames"]) > 0 ? var.sle12sp5_buildhost_configuration["hostnames"][0] : null
sle12sp5_terminal_mac = var.sle12sp5_terminal_configuration["private_mac"]
sle15sp3_buildhost = length(var.sle15sp3_buildhost_configuration["hostnames"]) > 0 ? var.sle15sp3_buildhost_configuration["hostnames"][0] : null
sle15sp3_terminal_mac = var.sle15sp3_terminal_configuration["private_mac"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the cleanup.

Add support to sles15sp6 and sp7 buildhost
@maximenoel8 maximenoel8 merged commit f03f1b8 into uyuni-project:master Nov 6, 2025
2 checks passed
@maximenoel8 maximenoel8 deleted the retail_buildhost_sp6 branch November 6, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants