category-ads: clean up and enhancement #2909
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drop some problematic/unreliable/stale rules
drop some problematic/unreliable/stale rules
drop some problematic/unreliable/stale rules
drop some problematic/unreliable/stale rules
drop some problematic/unreliable/stale rules
drop some problematic/unreliable/stale rules
It should be safe to be included now. This reverts commit 24c112a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are many problematic/unreliable/stale ad rules in this repo. Some seem to be from other old/dead adblcok projects (e.g. yhosts). It's hard for *ray users to locate/fix problems related to wrong blockings, and few person tried to update these rules or report bugs.
The principle of this pr is removing problematic/unreliable/stale rules and keeping/adding explicit/safe ones, which should be more suitable for the situation in *ray.
This pr may causing some reduction in blocking effectiveness while improving accuracy. Please comment if you have any objections/suggestions, or I'll merge this in a month.