Skip to content

Conversation

@Artur-
Copy link
Member

@Artur- Artur- commented Sep 20, 2025

  • Add script that updates dependencies based on branch (patch for non-main, latest for main)
  • Add GitHub workflow to run weekly and create PRs for main, 24.9, and 24.8 branches
  • Workflow runs every Monday at 04:00 UTC

🤖 Generated with Claude Code

@github-actions
Copy link

github-actions bot commented Sep 20, 2025

Test Results

1 279 files  ± 0  1 279 suites  ±0   1h 17m 24s ⏱️ + 2m 39s
8 872 tests ± 0  8 805 ✅ ± 0  67 💤 ±0  0 ❌ ±0 
9 330 runs  +22  9 253 ✅ +22  77 💤 ±0  0 ❌ ±0 

Results for commit a2c6251. ± Comparison against base commit 4c87bac.

♻️ This comment has been updated with latest results.

@Artur-
Copy link
Member Author

Artur- commented Sep 22, 2025

This would need some changes to use vaadin-bot or whatever should be used @manolo. Not sure how to test it either - the script itself works but the action is unclear

- Add script that updates dependencies based on branch (patch for non-main, latest for main)
- Add GitHub workflow to run weekly and create PRs for main, 24.9, and 24.8 branches
- Workflow runs every Monday at 04:00 UTC

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@Artur- Artur- force-pushed the update-frontend-deps branch from f5dfb8f to 40ec062 Compare September 29, 2025 09:34
@sonarqubecloud
Copy link

@mcollovati
Copy link
Collaborator

Running the script on maintenance branches causes the build to succeed with no errors if there are deprecated packages that do not have a patch available but require a major version bump.

Could the script run npx [email protected] --no-deprecated right after the upgrade attempt and make the build fail if deprecation warnings were found?

This way we could manually review each package and make a PR manually.

Artur- and others added 3 commits October 30, 2025 11:30
Add validation step to detect deprecated packages after running
npm-check-updates. On maintenance branches where only patch updates
are allowed, deprecated packages requiring major version bumps will
cause the workflow to fail, alerting maintainers to manually review.

Changes:
- Rename script: update-frontend-depdendencies.sh → update-frontend-dependencies.sh
- Add deprecated package check using `npm-check-updates --no-deprecated`
- Exit with error code 1 when deprecated packages are found
- Remove `|| true` from workflow to propagate failures
- Fix typo in workflow filename reference

This prevents silent failures where deprecated packages remain in
maintenance branches because no patch version is available.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@sonarqubecloud
Copy link

@Artur-
Copy link
Member Author

Artur- commented Oct 30, 2025

Could the script run npx [email protected] --no-deprecated right after the upgrade attempt and make the build fail if deprecation warnings were found?

Updated the script with that

@Artur-
Copy link
Member Author

Artur- commented Oct 30, 2025

Instead of running once a week, maybe it would be better if it ran once a day, used a dedicated branch so if a PR is left open, it can push additional updates in there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants