fix: always wait for navigated event for title #22494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caalador
force-pushed
the
issues/21171-history-title
branch
from
9a2f2b0 to
8eac7fd
Compare
When running with react-router always wait for vaadin-navigated event before updating the title. Fixes #21171
caalador
force-pushed
the
issues/21171-history-title
branch
from
8eac7fd to
630c2e9
Compare
platosha
requested changes
Oct 14, 2025
flow-server/src/main/resources/com/vaadin/flow/server/frontend/Flow.tsx
Outdated
Show resolved
Hide resolved
flow-server/src/main/resources/com/vaadin/flow/server/frontend/Flow.tsx
Outdated
Show resolved
Hide resolved
Add missing set navigation flag places.
platosha
reviewed
Oct 14, 2025
flow-server/src/main/resources/com/vaadin/flow/server/frontend/Flow.tsx
Outdated
Show resolved
Hide resolved
platosha
approved these changes
Oct 14, 2025
|
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 15, 2025
When running with react-router always wait for vaadin-navigated event before updating the title. Fixes #21171
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 15, 2025
When running with react-router always wait for vaadin-navigated event before updating the title. Fixes #21171
vaadin-bot
added a commit
that referenced
this pull request
Oct 15, 2025
When running with react-router always wait for vaadin-navigated event before updating the title. Fixes #21171 Co-authored-by: caalador <[email protected]>
vaadin-bot
added a commit
that referenced
this pull request
Oct 15, 2025
When running with react-router always wait for vaadin-navigated event before updating the title. Fixes #21171 Co-authored-by: caalador <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running with react-router
always wait for vaadin-navigated
event before updating the title.
In these cases the title update is
always from the server.
Fixes #21171