Bundle compatibility client for OSGI #12422
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you for the contribution. In the pom.xml line 53 seems to be code formatting issue, perhaps you used tabs instead of spaces. |
|
@chrisnaan Thanks for quick action. I am curious to know, are you using OSGi with Liferay or Karaf ? |
We're using Liferay DXP 7.3, we have some legacy Vaadin 7 code we need to get working on Liferay 7.3 |
|
@TatuLund I don't think this is ready to merge yet, as there are dependencies this module uses that aren't osgi modules either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added to maven build to add OSGI manifest entries.
Fixes #11660
Check when you have completed
[ x] Valid tests for the pull request
[ x] Contributing guidelines implemented