feat!: upgrade to depend on React 19 #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
commented
Sep 23, 2025
| // Components with slot attribute should stay in light DOM. | ||
| const slottedChildren = children.filter((child): child is ReactNode => { | ||
| return isValidElement(child) && child.props.slot; | ||
| return isValidElement(child) && (child.props as any).slot; |
There was a problem hiding this comment.
Related to this change:
The props of React elements now default to unknown instead of any if the element is typed as ReactElement.
See DefinitelyTyped/DefinitelyTyped#69022 - "Changes to Type Parameters" - "ReactElement"
web-padawan
commented
Sep 23, 2025
| config?: RendererConfig<W>, | ||
| ): UseRendererResult<W> { | ||
| const [map, update] = useReducer<typeof rendererReducer<W>>(rendererReducer, initialState); | ||
| const [map, update] = useReducer(rendererReducer, initialState); |
There was a problem hiding this comment.
Related to this change:
The new best practice is not to pass type arguments to useReducer.
See DefinitelyTyped/DefinitelyTyped#69022 - "Changes to Type Parameters" - "useReducer"
|
Regarding this error - we've seen it before and had to downgrade types in #308: |
sissbruecker
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgraded
reactand related dependencies to v19, fixed two compilation errors due to@types/reactbreaking changes.Type of change