feat: add itemLabelGenerator property to select, combo box and multi select combo box #10066
+551
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue linked describes combo-box and the PR is for select, should there be another issue? |
|
Wouldn't the feature make sense for select, combo-box and also multi-select-combo-box? |
|
There are many merge conflicts, looks like the change was created from an early version where |
|
Yes, I will rebase on latest main |
Artur-
force-pushed
the
item-label-generator
branch
2 times, most recently
from
7b1e301 to
64377b6
Compare
|
Was easier to code from scratch again.. |
…select-combo-box Implement itemLabelGenerator function property that allows custom label generation for items. The generator function receives an item and returns a string label, taking precedence over itemLabelPath when both are defined. - Add itemLabelGenerator to vaadin-select for custom dropdown item labels - Add itemLabelGenerator to vaadin-combo-box with support for filtering by generated labels - Multi-select-combo-box inherits itemLabelGenerator for both dropdown and chip labels - Add comprehensive tests for all three components - Update dev examples to demonstrate the new feature Fixes #8333 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add itemLabelGenerator type definition to SelectBaseMixinClass - Add itemLabelGenerator type definition to ComboBoxItemsMixinClass - MultiSelectComboBoxMixinClass inherits the type automatically via ComboBoxItemsMixinClass 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Follow the existing pattern of counting overflow chip in total chip count - Use getChips() helper function consistently with existing tests - Access chip labels at correct indices (skip overflow chip at [0]) - Set proper width and await nextRender for consistent chip rendering All tests now pass: - select: 6/6 tests ✅ - combo-box: 8/8 tests ✅ - multi-select-combo-box: 9/9 tests ✅ 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Artur-
force-pushed
the
item-label-generator
branch
from
d0e011f to
b1b9607
Compare
|
Artur-
changed the title
Artur-
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new itemLabelGenerator function property to vaadin-select that allows customizing how item labels are generated from item objects. This enables users to display custom text for items without modifying the underlying data structure.
Fixes #8333
🤖 Generated with Claude Code