Skip to content

Conversation

sissbruecker
Copy link
Contributor

Description

Part of #10109

Type of change

  • Bugfix

Comment on lines 82 to 84
-webkit-text-size-adjust: 100%;
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should these be overridden?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea, they were grouped together with the other properties in the Lumo version of the reset so I assumed they were related. Removed them for now.

@sissbruecker sissbruecker marked this pull request as ready for review September 1, 2025 06:44
Copy link
Member

@jouni jouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple more inherited properties, text-indent and word-spacing.

Co-authored-by: Jouni Koivuviita <[email protected]>
Copy link

sonarqubecloud bot commented Sep 9, 2025

@sissbruecker sissbruecker requested a review from jouni September 9, 2025 06:34
@sissbruecker sissbruecker merged commit 65fd684 into main Sep 9, 2025
9 checks passed
@sissbruecker sissbruecker deleted the fix/overlay-text-style-reset branch September 9, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants