feat: Add support for initially closed accordion #10114
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Hmm, I guess this is already supported in flow with var accordion = new Accordion();
accordion.close();I guess in lit you'd just set the "opened" property to <body>
<vaadin-accordion>
<vaadin-accordion-panel>
<vaadin-accordion-heading slot="summary">Panel 1</vaadin-accordion-heading>
<div>Panel 1 content</div>
</vaadin-accordion-panel>
<vaadin-accordion-panel>
<vaadin-accordion-heading slot="summary">Panel 2</vaadin-accordion-heading>
<div>Panel 2 content</div>
</vaadin-accordion-panel>
<vaadin-accordion-panel summary="Panel 3">
<div>Panel 3 content</div>
</vaadin-accordion-panel>
<vaadin-accordion-panel summary="Panel 4 (disabled)" disabled>
<div>Panel 4 content</div>
</vaadin-accordion-panel>
</vaadin-accordion>
<button onclick="document.querySelector('vaadin-accordion').open = null">Close</button>
</body> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for accordion to load without any opened panels.
For this, I introduced "closed" attribute / property that does not interfere with the old logic if it's not specified.
Using this as an exercise to learn web-components better, so detailed feedback would be appreciated. It's OK if this PR is closed / not accepted.
Fixes # (issue)
vaadin/flow-components#1638
Type of change
Checklist
Additional for
Featuretype of changeNothing specific discussed, but straight forward implementation in my opinion.