fix: use proper item comparison #10411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
vursen
approved these changes
Oct 31, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 31, 2025
web-padawan
pushed a commit
that referenced
this pull request
Oct 31, 2025
Co-authored-by: Sascha Ißbrücker <[email protected]>
Collaborator
|
This ticket/PR has been released with Vaadin 25.0.0-beta4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Grid Pro cancels editing if the item in the edited row does not match the edited item anymore. However it always compares by item reference, which does not work if you replace the item instance after changing a field.
This fixes it by comparing by item ID, which would fall back to comparing by reference if no ID is defined.
Type of change