refactor: scroller and virtual-list overflow-indicators #10433
Conversation
jouni
force-pushed
the
refactor/overflow-indicators
branch
2 times, most recently
from
9673c03 to
0e96229
Compare
jouni
force-pushed
the
refactor/overflow-indicators
branch
from
0e96229 to
e6776af
Compare
| flex: 1; | ||
| align-self: stretch; | ||
| box-sizing: border-box; | ||
| padding: 0 !important; |
There was a problem hiding this comment.
Just to double check, do we need to enforce !important here to avoid messing up calculations?
There was a problem hiding this comment.
Yeah, that was the thinking. I went back and forth with this, and perhaps we should do it, and only document that if you use the standard padding property on the host it’ll break the overflow indicators.
| --vaadin-virtual-list-padding-block: 0px; | ||
| --vaadin-virtual-list-padding-inline: 0px; |
There was a problem hiding this comment.
Are these supposed to be used by Aura? Also, should we document them in the JSDoc API?
There was a problem hiding this comment.
I don't think themes would set those by default. They are intended more for app devs if they want to apply padding to the scroll containers. But regardless, they should be documented, yes.
|
Add support for setting padding on scroller and virtual-list components while still keeping the overflow indicators visually in correct locations.