Skip to content

Conversation

@web-padawan
Copy link
Member

Description

Part of #10417

Updated grid to just inherit border-radius on the scroller element.

Type of change

  • Refactor

@jouni
Copy link
Member

jouni commented Nov 5, 2025

I’m now thinking we should remove the --_border-width and --_border-radius properties, and add overflow: hidden on the host. I don't remember anymore why I wanted to avoid that. Then we don't need to update the screenshots.

We could also simplify the no-border variant implementation, avoid the :not() selector and just override border and border-radius to zero for that variant.

@web-padawan web-padawan force-pushed the refactor/grid-scroller-radius branch from 025f11b to 957e6b0 Compare November 5, 2025 16:02
@web-padawan
Copy link
Member Author

web-padawan commented Nov 5, 2025

@jouni updated, please check if I got it right. Setting overflow: hidden affected the dragover screenshot.

UPD: some tests also failed because of the change, we should double check that as well.

@jouni
Copy link
Member

jouni commented Nov 6, 2025

please check if I got it right

Yeah, this is what I meant.

Setting overflow: hidden affected the dragover screenshot.

That’s weird. That's set using outline on the host, so it should still be visible.

UPD: ah, it relied on the var(--_border-width) property, so it’s now not inset properly on top of the host border.

@web-padawan web-padawan force-pushed the refactor/grid-scroller-radius branch from 957e6b0 to 6fb69a3 Compare November 6, 2025 12:30
@web-padawan
Copy link
Member Author

@jouni Updated the outline styles. Regarding unit test - I had to set overflow: visible for the all-rows-visible to prevent regression for the issue fixed in #8535.

@web-padawan web-padawan requested a review from jouni November 6, 2025 12:50
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 6, 2025

@web-padawan web-padawan merged commit 10d7c35 into main Nov 6, 2025
9 checks passed
@web-padawan web-padawan deleted the refactor/grid-scroller-radius branch November 6, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants