Skip to content

Conversation

@cszhjh
Copy link
Member

@cszhjh cszhjh commented Apr 6, 2025

Checklist

List of tasks you have already done and plan to do.

  • Fix linting errors
  • Tests have been added / updated (or snapshots)

Change information

Describe your modifications here.

Issues

close #1797

Related Links

Links related to this pr.

@vercel
Copy link

vercel bot commented Apr 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
varlet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2025 4:29pm

@vercel
Copy link

vercel bot commented Apr 6, 2025

@cszhjh is attempting to deploy a commit to the varletjs Team on Vercel.

A member of the Team first needs to authorize it.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Apr 6, 2025

Open in StackBlitz

@varlet/cli

npm i https://pkg.pr.new/@varlet/cli@1875

@varlet/icons

npm i https://pkg.pr.new/@varlet/icons@1875

@varlet/import-resolver

npm i https://pkg.pr.new/@varlet/import-resolver@1875

@varlet/preset-tailwindcss

npm i https://pkg.pr.new/@varlet/preset-tailwindcss@1875

@varlet/preset-unocss

npm i https://pkg.pr.new/@varlet/preset-unocss@1875

@varlet/shared

npm i https://pkg.pr.new/@varlet/shared@1875

@varlet/touch-emulator

npm i https://pkg.pr.new/@varlet/touch-emulator@1875

@varlet/ui

npm i https://pkg.pr.new/@varlet/ui@1875

@varlet/use

npm i https://pkg.pr.new/@varlet/use@1875

@varlet/vite-plugins

npm i https://pkg.pr.new/@varlet/vite-plugins@1875

commit: a4d9c5a

@haoziqaq
Copy link
Member

haoziqaq commented Apr 29, 2025

总体感觉非常好,几个修改意见:

  1. var-tour-step 的样式风格和 api 设计感觉应该与 dialog 组件有一定的映射关系,毕竟都是 “对话框”。
  2. 内置的关闭按钮,最好换一种风格。
    image
  3. indicators 最好是能做到点击时切换步骤
  4. 增加 esc 的键盘触发关闭
  5. primary 的 indicator 未选中的状态颜色不太明显,可能需要优化一下
    image

@haoziqaq
Copy link
Member

haoziqaq commented May 5, 2025

TourSteps 这个组件可以考虑一下使用 useChildren useParent 之后,是否还是必要的。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] New component Tour

2 participants