Add optional argument forcing syslog parcing to one of both RFCs #1051
Conversation
Allows giving priority to the older RFC 3164 over the newer RFC 5424. Defaults to the original behaviour of using the newer format over the older.
Ditch support for structured data inside RFC3164 messages
pront
added
the
meta: awaiting author
itkovian
force-pushed
the
parse-syslog-force-format
branch
from
91535e8 to
dac266f
Compare
itkovian
force-pushed
the
parse-syslog-force-format
branch
from
e670d8e to
42a78be
Compare
itkovian
force-pushed
the
parse-syslog-force-format
branch
from
f5ddf86 to
1d24034
Compare
itkovian
force-pushed
the
parse-syslog-force-format
branch
from
1d24034 to
9e2d37b
Compare
|
@pront Formatting addressed. |
|
@pront If I want fmt to succeed, the formatting will change (at least on my machine). |
| strip-ansi-escapes = { version = "0.2", optional = true } | ||
| snap = { version = "1", optional = true } | ||
| syslog_loose = { version = "0.21", optional = true } | ||
| syslog_loose = { git = "https://github.com/itkovian/syslog-loose", rev = "72bb2608ff942112d688626143b9bf8187a2f24f", optional = true } |
There was a problem hiding this comment.
Can you submit this as a PR to the original repo please. I'll look into it asap..
There was a problem hiding this comment.
Sure, but it's not really doing what you want as mentioned in StephenWakely/syslog-loose#37 I think.
There was a problem hiding this comment.
Ah I see. Yeah we can't really just remove structured data for 3164, that would be quite a breaking change. Despite not being strictly in the spec, there are systems such as rsyslog that push out 3164 messages with structured data. The joys of syslog!
I realise this issue has been outstanding for a while now, so I'll see if I can get some time to bump it up.
There was a problem hiding this comment.
This should be good with version 0.22 of syslog_loose now.
There was a problem hiding this comment.
I'll try and change this asap. Thank you!
Allows giving priority to the older RFC 3164 over the newer RFC 5424. Defaults to the original behaviour of using the newer format over the older.
This PR address #1043.