-
Notifications
You must be signed in to change notification settings - Fork 5.9k
chore: Context in message metadata #1181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
FranciscoMoretti
wants to merge
1
commit into
vercel:main
from
FranciscoMoretti:francisco/context-in-message-metadata
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| ALTER TABLE "Message_v2" ADD COLUMN "lastContext" jsonb;--> statement-breakpoint | ||
| ALTER TABLE "Chat" DROP COLUMN IF EXISTS "lastContext"; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
lastContextfield is hardcoded tonullwhen saving messages, but the client receives usage data through messageMetadata, creating a disconnect between stored and displayed data.View Details
📝 Patch Details
Analysis
Usage Data Loss Bug in Chat API
Summary
The chat API is losing usage data (token counts) when messages are persisted to the database, creating a disconnect between what users see during active sessions and what's available after page refreshes.
Technical Details
The Problem
In
app/(chat)/api/chat/route.ts, theonFinishcallback ofcreateUIMessageStreamhardcodeslastContext: nullwhen saving messages to the database (line 213), despite having access to usage data from the underlyingstreamTextoperation.Data Flow Analysis
messageMetadatafunction (lines 189-198) correctly sends usage data to clients viapart.totalUsagelastContextis hardcoded tonull, losing usage informationconvertToUIMessagesmapsmessage.lastContexttometadata.usage, resulting inundefinedinstead of actual usage dataDatabase Schema Evidence
The database schema confirms
lastContextis designed to store usage data:API Documentation Verification
According to the AI SDK documentation,
streamText'sonFinishcallback provides atotalUsageparameter containing token usage information. The current implementation fails to capture this data.Impact
Solution Implemented
The fix captures usage data from
streamText'sonFinishcallback and stores it in the database:totalUsagefrom thestreamTextresultonFinishcallback onstreamTextto capture the usage dataVerification
This fix ensures usage data persists across sessions while maintaining backward compatibility with existing null values for user messages.