[bug fix] analytical place with graphics no longer segfault #3273
Conversation
updated the size of some graphics resources after ap
github-actions
bot
added
VPR
vpr/src/base/place_and_route.cpp
Outdated
| #ifndef NO_GRAPHICS | ||
| // update graphic resources incase of clustering changes | ||
| if (get_draw_state_vars()) { | ||
| get_draw_state_vars()->refresh_graphic_resources_after_cluster_change(); |
There was a problem hiding this comment.
I do not think this bit of code belongs in this function. I recommend moving it somewhere else. Perhaps even into its own function. Post-place sync is not doing things related to drawing directly.
There was a problem hiding this comment.
I moved this to a full legalizer member function and it is called at the end of all versions of legalize().
Now a full legalize method is created to update drawing cluster data structure. It is called at the end of each legalize implementation.
|
@robluo : one remaining thing to investigate, to see if we can have a simpler solution: Do we need a refresh function like this, or could we just move where the drawing state is initialized? It seems like we usually initialize it after clustering, but with analytical placement enabled somehow it gets initialized before we've completed clustering. Could we just move it so it is called after clustering, whether analytical placement is enabled or not? |
3 participants
Analytical placement update clustering global context later compared to original placement, but the graphic resources are initialized earlier in vpr flow. This causes a segmentation fault when enabling both display on and analytical place.
This PR fixes the issue.
Description
Resized graphic resources (block_color and net_color) in post_place_sync().
Related Issue
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: