Skip to content

Conversation

soheilshahrouz
Copy link
Contributor

This made graphics more responsive when edges are drawn.

@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool libarchfpga Library for handling FPGA Architecture descriptions lang-cpp C/C++ code labels Oct 7, 2025
Copy link
Contributor

@AlexandreSinger AlexandreSinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I just had one comment about the name of the map.

TBH, if this does make a noticeable difference, we should really consider not using a map for this lookup. This is showing that the compiler is actually creating the map object and we are looking up into that map at runtime. Maps are pretty slow when we are doing a lookup like this. We should really be using a simple helper function. This will likely make the lookup much cheaper.

We can ignore my above comment, since your change only makes the code better, but we should prevent code like this in the future in my opinion.

Copy link
Contributor

@amin1377 amin1377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Soheil! Thanks!

@soheilshahrouz soheilshahrouz merged commit 42ccf87 into master Oct 8, 2025
30 checks passed
@soheilshahrouz soheilshahrouz deleted the temp_draw_edges_cleanup branch October 8, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang-cpp C/C++ code libarchfpga Library for handling FPGA Architecture descriptions VPR VPR FPGA Placement & Routing Tool

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants