Fix GUI message consistency, restore signal-handler checkpointing, and update documentation image #3301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
VPR
-Makes the message shown in the gui and drawed state consistent without requiring user interaction. -Makes the signal handler checkpointing functional again when enabled.
haydar-c
force-pushed
the
update_images_and_gui_message
branch
from
fd15259 to
6d48c27
Compare
vpr/src/base/vpr_signal_handler.cpp
Outdated
|
|
||
| std::string placer_checkpoint_file = "placer_checkpoint.place"; | ||
| VTR_LOG("Attempting to checkpoint current placement to file: %s\n", placer_checkpoint_file.c_str()); | ||
| print_place(nullptr, nullptr, placer_checkpoint_file.c_str(), g_vpr_ctx.placement().block_locs()); |
There was a problem hiding this comment.
In the placement stage, g_vpr_ctx.placement().block_locs() does not contain block locations. It is stored locally withing a Placer object.
vpr/src/base/vpr_signal_handler.cpp
Outdated
| VTR_LOG("Recieved three uncleared SIGINTs: Exiting...\n"); | ||
| std::quick_exit(INTERRUPTED_EXIT_CODE); | ||
| } | ||
| VTR_LOG("Recieved SIGINT: Attempting to checkpoint then exit...\n"); |
There was a problem hiding this comment.
I’m not sure if it’s safe to call VTR_LOG from a signal handler. It probably calls standard library functions internally, which are not safe to use in a signal handler.
and save block locs after each SA temprature update when signal handler enabled.
vaughnbetz
requested changes
Oct 10, 2025
| void checkpoint(); | ||
|
|
||
| std::atomic<int> uncleared_sigint_count(0); | ||
| static inline void safe_write(const char* msg) { |
There was a problem hiding this comment.
Need a doxygen comment; what is this for?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: