Add interposer wires #3305

soheilshahrouz · 2025-10-14T16:35:44Z

This PR adds support for inter-die wires defined using the <interdie_wire> tag under <interposer_cut> in the architecture file. The graphics code has been updated accordingly to visualize these wires correctly.

…d_interposer_wires

…er_connections

…uld be far from each other

…licts

AmirhosseinPoolad · 2025-10-16T22:01:58Z

Soheil changed the --device behaviour to be more aligned with the documentation in this PR. While the docs say that if --device is not set, the auto sized device would be selected, previously it would select some fixed size device if there was no auto sized device defined in the architecture file. Now it errors out if --device is not set and there's no auto sized device. This is the reason for the current strong test failure.

AmirhosseinPoolad

Reviewed until (but not including) draw_rr_edges.cpp so far.

libs/libarchfpga/src/physical_types.h

libs/libarchfpga/src/scatter_gather_types.h

vpr/src/draw/draw.cpp

vpr/src/draw/draw_basic.cpp

vaughnbetz · 2025-10-17T21:45:03Z

vpr/src/draw/draw.cpp

+    if (!draw_state->show_graphics) {
        ezgl::set_disable_event_loop(true);
-    else
+    } else {


Personally I prefe
if () {
// stuff
}
else { // I broke this line.

}

vaughnbetz · 2025-10-17T21:53:14Z

vpr/src/draw/draw_basic.cpp

+                    // flag whether the current location is highlighted with a special color or not
+                    bool current_loc_is_highlighted = false;
+
+                    if (placer_breakpoint_reached()) {


Could move this into a routine with a proper comment. I think this is checking if we've stopped at a placer breakpoint and if the block is in a special list of blocks to be coloured (due to being part of a move).

vaughnbetz · 2025-10-17T22:11:49Z

vpr/src/draw/draw_rr_edges.cpp

-                // since no U-turns from_tracks must be INC as well
-                x1 = draw_coords->tile_x[to_xlow - 1]
-                     + draw_coords->get_tile_width();
+                if (rr_graph.node_direction(from_node) == Direction::DEC) {


I think commenting why you don't draw from the ends in this case would be good.

vaughnbetz · 2025-10-17T22:12:51Z

vpr/src/route/rr_graph_generation/build_scatter_gathers.h

                                                                         vtr::RngContainer& rng,
                                                                         vtr::NdMatrix<std::vector<t_bottleneck_link>, 2>& interdie_3d_links);
+
+void convert_interposer_cuts_to_sg_patterns(const std::vector<t_layer_def>& interposer_inf,


Doxygen comment.

vaughnbetz · 2025-10-17T22:13:23Z

vpr/src/route/rr_graph_generation/rr_graph.cpp

 static int get_delayless_switch_id(const t_det_routing_arch& det_routing_arch,
                                   bool load_rr_graph);

+static void add_and_connect_non_3d_sg_links(RRGraphBuilder& rr_graph_builder,


Doxygen comment.
Make sure you mention this should only be called once the scatter-gather links/nodes are in the spatial lookup.
And say what the function does.

Make sure it says you're passing data back through the non_3d_... reference.

vaughnbetz · 2025-10-17T22:19:37Z

vpr/src/route/rr_graph_generation/rr_node_indices.cpp

+
+        vtr::NdMatrix<int, 3>& ptc_matrix = (chan_type == e_rr_type::CHANX) ? chanx_ptc : chany_ptc;
+
+        int ptc = 0;


Explain why you get the max (want to ensure ptc_num is unique along the length of the rr_node we're creating for this sg_link.

vaughnbetz · 2025-10-17T22:22:41Z

vpr/src/route/rr_graph_generation/rr_node_indices.h

                                              const vtr::NdMatrix<std::vector<t_bottleneck_link>, 2>& interdie_3d_links,
                                              int* index);

+std::vector<std::pair<RRNodeId, int>> alloc_and_load_non_3d_sg_pattern_rr_node_indices(RRGraphBuilder& rr_graph_builder,


Doxygen comment.

vaughnbetz · 2025-10-17T22:31:06Z

vpr/src/route/rr_graph_generation/rr_graph.cpp

+                                                                     : CHANX_COST_INDEX_START + num_seg_types_x + link.parallel_segment_index;
+        rr_graph_builder.set_node_cost_index(node_id, RRIndexedDataId(cons_index));
+
+        float R = 0;


This should come from the segment defined to be used by the sg_link.
Also do the same for CHANZ wires.

vaughnbetz · 2025-10-17T22:31:12Z

vpr/src/route/rr_graph_generation/rr_graph.cpp

+
+        VTR_ASSERT_SAFE(src_loc.layer_num == dst_loc.layer_num);
+        const int layer = src_loc.layer_num;
+


could this be refactored with another block of code (which I think was the spatial lookup insertion code) to have a helper once)?

vaughnbetz · 2025-10-17T22:31:59Z

vpr/src/route/rr_graph_generation/rr_graph.cpp

+
+    for (size_t i = 0; i < num_links; i++) {
+
+        const t_bottleneck_link& link = sg_links[i];


Comment the overall flow / algorithm of this routine, or the major code blocks.

Unless the comment at the func declaration has enough detail (once it's written).

soheilshahrouz added 30 commits September 18, 2025 18:39

Merge remote-tracking branch 'origin/interposer_parsing' into temp_ad…

6596c75

…d_interposer_wires

add convert_interposer_cuts_to_sg_patterns()

c694846

replace x_spec/y_spec with a t_specified_loc member var

1c6a086

pass scatter-gather's specified loc to sb_not_here()

4376303

Merge branch 'temp_3d_sg' into temp_add_interposer_wires

5308b87

Merge remote-tracking branch 'origin/interposer_parsing' into temp_ad…

0aca585

…d_interposer_wires

add cut locs to DeviceGrid

9d705d9

call convert_interposer_cuts_to_sg_patterns() in RR graph generation

f0b8ffd

get rid of compilation errors in tests

2f0bfb0

pass the copied version of sg_patterns to alloc_and_load_scatter_gath…

3482540

…er_connections

add alloc_and_load_non_3d_sg_pattern_rr_node_indices()

b5a8ec2

remove is_flat from arguments of alloc_and_load_rr_graph()

b47ec96

add add_and_connect_non_3d_sg_links()

d585890

Merge branch 'temp_3d_sg' into temp_add_interposer_wires

e7a88eb

call add_and_connect_non_3d_sg_links()

d55fbd9

Merge branch 'temp_3d_sg' into temp_add_interposer_wires

899c855

renamed shadowing vars

1a503e1

bugfix: cur_loc was added twice to offest

be6af33

updated architecture file

99b6b43

compute chan width from RR graph and store in global context

c923574

fix commenting style in init_draw_coords()

0d66efc

bugfix: update drawing when update_screen() is called instead

1294079

use chand widtd extracted from rr graph to specify how far blocks sho…

db99b4c

…uld be far from each other

initialize cost index for interposer wires

5d8045b

Merge branch 'temp_draw_edges_cleanup' into temp_add_interposer_wires

ccf70b1

avoid repetitive computation in draw_get_rr_chan_bbox()

a762189

draw U-turn connections in SB for CHANY DEC->INC

6adced3

draw nodes on top of edges

9ace63f

Merge branch 'temp_interposer_cut_dim' into temp_add_interposer_wires

491a72b

clean drawplace()

5a94c8b

soheilshahrouz added 6 commits October 8, 2025 18:12

Merge branch 'temp_interposer_cut_dim' into temp_add_interposer_wires

7229998

fix compilation errors due to enum name change

a28679e

doxygen comment for rr_chanx_width and rr_chany_width

7311edf

ifndef NO_GRAPHICS in draw_interposer files

210a8e0

enum class e_pic_type

c101faa

Merge branch 'temp_interposer_cut_dim' into temp_add_interposer_wires

57c3655

github-actions bot added VPR VPR FPGA Placement & Routing Tool libarchfpga Library for handling FPGA Architecture descriptions docs Documentation lang-cpp C/C++ code labels Oct 14, 2025

soheilshahrouz added 7 commits October 15, 2025 13:43

update config files with --device command line arg

1074e27

Merge branch 'master' into temp_add_interposer_wires and resolve conf…

ec5332a

…licts

remove unused function

cc19794

make format

a8ef54b

draw interposer edges

b47b0ba

update the interposer arch file

ad376ef

Merge branch 'master' into temp_add_interposer_wires

e70f165

soheilshahrouz changed the title ~~[WIP] Add interposer wires~~ Add interposer wires Oct 16, 2025

soheilshahrouz requested review from AmirhosseinPoolad and vaughnbetz October 16, 2025 21:10

AmirhosseinPoolad reviewed Oct 16, 2025

View reviewed changes

libs/libarchfpga/src/physical_types.h Outdated Show resolved Hide resolved

libs/libarchfpga/src/scatter_gather_types.h Outdated Show resolved Hide resolved

vpr/src/draw/draw.cpp Outdated Show resolved Hide resolved

vpr/src/draw/draw_basic.cpp Outdated Show resolved Hide resolved

soheilshahrouz added 4 commits October 17, 2025 12:43

update doxygen comments

2afc126

remove duplicate code

b3627f5

simplify the logic in draw_place and add a doxygen comment

7eb7c4c

separate tasks for fixed custom grid

97bd7b1

vaughnbetz requested changes Oct 17, 2025

View reviewed changes


		vtr::NdMatrix<int, 3>& ptc_matrix = (chan_type == e_rr_type::CHANX) ? chanx_ptc : chany_ptc;

		int ptc = 0;


		VTR_ASSERT_SAFE(src_loc.layer_num == dst_loc.layer_num);
		const int layer = src_loc.layer_num;


		for (size_t i = 0; i < num_links; i++) {

		const t_bottleneck_link& link = sg_links[i];

Add interposer wires #3305

Are you sure you want to change the base?

Add interposer wires #3305

Uh oh!

Conversation

soheilshahrouz commented Oct 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AmirhosseinPoolad commented Oct 16, 2025

Uh oh!

AmirhosseinPoolad left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

soheilshahrouz commented Oct 14, 2025 •

edited

Loading