Update victorops-twilio.js #28

cmillane · 2021-06-28T22:32:10Z

Adjustments to accommodate Twilio's Dialverb changes. Also updated branding from VictorOps to Splunk On-Call

Adjustments to accommodate Twilio's Dialverb changes. Also updated rebranding from VictorOps to Splunk On-Call

dscott-splunk · 2021-06-29T01:52:05Z

victorops-twilio.js

-    noTeam: (team) => `Team ${team} does not exist. Please contact your administrator to fix the problem.`
+    voCallNotAnswered: (caller) => `Missed call from ${caller}.`,
+    voCallCompleted: (user, caller, log) => `${user} answered a call from ${caller}. ${log}`,
+     noTeam: (team) => `Team ${team} does not exist. Please contact your administrator to fix the problem.`


nit: extra space

dscott-splunk · 2021-06-29T01:53:13Z

victorops-twilio.js

    const escPolicyUrlArray = createEscPolicyUrls(context, teamsArray[0].slug);
    const phoneNumberArray = escPolicyUrlArray.map(url => getPhoneNumbers(context, url, teamsArray[0].name, teamsArray[0].escPolicyName));
-
+    phoneNumberArray.length = 1;


delete this, it was added so we wouldn't have to wait through multiple calls for testing

dscott-splunk · 2021-06-29T01:53:50Z

victorops-twilio.js

    let {detailedLog, realCallerId} = payload;
-    let phoneNumber;
-
+    let phoneNumber; 


nit: trailing space

dscott-splunk · 2021-06-29T01:56:01Z

victorops-twilio.js

-          phoneNumber.phone
-        );
-      }
+      return postToVictorOps(event,context,payload);


nit:
return postToVictorOps(event, context, payload);

dscott-splunk · 2021-06-29T01:56:26Z

victorops-twilio.js

-      }
+      return postToVictorOps(event,context,payload);
    }
+    else{


nit:
} else {

dscott-splunk · 2021-06-29T01:57:41Z

victorops-twilio.js

+                  detailedLog,
+                  phoneNumber,
+                  phoneNumbers,
+                  realCallerId,


duplicated realCallerId, delete second one

dscott-splunk · 2021-06-29T01:59:03Z

victorops-twilio.js

-        `${messages.attemptTranscription} ${messages.goodbye}`
-      );
+    if (DialCallStatus == 'completed' && DialBridged == 'true') {
+      return postToVictorOps(event,context,payload);


nit:
return postToVictorOps(event, context, payload);

dscott-splunk · 2021-06-29T01:59:21Z

victorops-twilio.js

-      );
+    if (DialCallStatus == 'completed' && DialBridged == 'true') {
+      return postToVictorOps(event,context,payload);
+    }


nit:
} else {

dscott-splunk · 2021-06-29T02:01:46Z

victorops-twilio.js

      return;
    }
-
+    //console.log(alert)


dscott-splunk · 2021-06-29T02:10:10Z

victorops-twilio.js

-        {voice},
-        `${messages.attemptTranscription} ${messages.goodbye}`
-      );
+    if (DialCallStatus == 'completed' && DialBridged == 'true') {


if (DialCallStatus === 'completed' && DialBridged == 'true') {

Using === prevents recovery alerts when the callee hangs up.

Whatever gets the result we want :)

dscott-splunk · 2021-06-29T02:10:42Z

victorops-twilio.js

+        {voice},
+        `${messages.otherPartyDisconnect} ${messages.goodbye}`
+      );
+      resolve(DialCallStatus == 'completed' && TranscriptionStatus !== 'failed' ? twiml : '');


resolve(DialCallStatus === 'completed' && TranscriptionStatus !== 'failed' ? twiml : '');

Using === prevents recovery alerts when the callee hangs up.

Performed further testing and revised the code

Addresses Twilio's upcoming Dialverb changes, VOSE-1461, and VOSE-1463

Update victorops-twilio.js

9390ef6

Adjustments to accommodate Twilio's Dialverb changes. Also updated rebranding from VictorOps to Splunk On-Call

dscott-splunk reviewed Jun 29, 2021

View reviewed changes

cmillane added 2 commits July 8, 2021 09:46

Update victorops-twilio.js

a47b3fd

Performed further testing and revised the code

Update victorops-twilio.js

7a86356

Addresses Twilio's upcoming Dialverb changes, VOSE-1461, and VOSE-1463

Uh oh!

Update victorops-twilio.js #28

Are you sure you want to change the base?

Update victorops-twilio.js #28

Uh oh!

Conversation

cmillane commented Jun 28, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cphillips2 Jul 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cphillips2 Jul 8, 2021 •

edited

Loading