Skip to content

Conversation

robwalch
Copy link
Collaborator

@robwalch robwalch commented Feb 11, 2025

This PR will...

Improve custom loader documentation

Why is this Pull Request needed?

Resolve recent loader issues:

Are there any points in the code the reviewer needs to double check?

Recent issues have been labelled "Custom loader":
https://github.com/video-dev/hls.js/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22Custom%20loader%22

TODOs:

  1. Handle specific types of requests (playlists, fragments, other): 7fec594
    a. config usage
    a. loader context usage
  2. Providing loader stats (type structure and dependencies)
  3. Extending existing loaders with composition vs inheritance (example covers inheritance and facade patterns)

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

Enhance existing docs to resolve current loader issues: #7012 #7010 #7007
TODO: Add "Custom loader" label to older issues https://github.com/video-dev/hls.js/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22Custom%20loader%22
Copy link
Collaborator

@itsjamie itsjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Rob.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants