Support models with primary keys not named "id" #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16.
Django models do not always have a field named "id". Declaring another field with
primary_key=True
removes the defaultid
field.Admin
*ListFilter
variations all havelookup_kwarg
attribute that provides exactly what we need: explicit target lookup without any string munging in application code. This also allows us to removeisChoiceField
entirely and always use thelookup_kwarg
provided by Django. Autocomplete AJAX always returns PK field underid
field.I tested these changes locally on a test project and adjusted the existing test to account for new fields. To support usual whitespace wrapping, I replaced string-based asserts with HTMLParser (built-in) to verify that there is exactly one tag matching given specification.