Skip to content

import BNGL model without scaling #1567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

import BNGL model without scaling #1567

wants to merge 1 commit into from
+14 −11

Conversation

jcschaff
Copy link
Member

@jcschaff jcschaff commented Jul 30, 2025 •
edited
Loading

see BNGL import erroneously scales initial conditions by 2e-5
BNGL import assumes are numbers are correct, and imports as either concentrations or molecules.

@jcschaff jcschaff self-assigned this Jul 30, 2025
@jcschaff jcschaff requested review from danv61 and vcellmike July 30, 2025 21:16
@jcschaff jcschaff linked an issue Jul 30, 2025 that may be closed by this pull request
BNGL import erroneously scales initial conditions by 2e-5 #1335
Open
danv61
danv61 approved these changes Aug 1, 2025
View reviewed changes
Copy link
Contributor

@danv61 danv61 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danv61 danv61 danv61 approved these changes

@vcellmike vcellmike Awaiting requested review from vcellmike

Assignees

@jcschaff jcschaff

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BNGL import erroneously scales initial conditions by 2e-5
2 participants
@jcschaff @danv61