"total" validation for NaN format #171
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found some cases when
totalattribute may not be defined asNumber/String/undefined, but could be aNaNformat implicitly or not.For example, my app using
node-progresslib and has no request validation for incoming dataContent-Lengthattribute.But it was actually passed into
const total = parseInt(contentLength, 10)asundefined.And
totalhas takenNaN.Eventually, it throws the errors like described in #166:
where
completeLengthtakesNaNfromtotal.Perhaps it could be more convenient to track if we missed a real
totalvalue transmitted if it throws when constructor ofProgressBarcalled.I will be grateful if someone responds to this. Thanks.