Skip to content

feat: add imports display in chunk details #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

liangmiQwQ
Copy link
Contributor

As permalink in #12 or #9, I've done a part of the import display in chunk details.

Current Situation

  • Added the number of imports displays
  • Added list of imports, and classify with badges & i-ph-file-duotone for import-statement and i-ph-lightning-duotone for dynamic-import
  • Added prop named showImports in order to avoid imports displaying in assets details component
Image

May Need to Discuss

The imports are only for displaying so far, should we show more info about it?

Options:

  • should we add a link and make a new details loader (like module, assets, plugins)
  • should we navigate to the target chunk in the chunk page?
  • keep display-only for now

In my opinion, I think maybe the first one is better?

(Note: I think the chunk displaying in assets details may also need a link)

@liangmiQwQ liangmiQwQ force-pushed the feat/add-display-chunk-details branch 3 times, most recently from 1b4fbee to 3100e49 Compare August 20, 2025 09:55
@liangmiQwQ
Copy link
Contributor Author

Anyway, I've done the link and the details loader (option one), It could be reused in other components. It may be a little rough and need ui adjust.

Screen Shot

@liangmiQwQ liangmiQwQ marked this pull request as ready for review August 21, 2025 00:09
@liangmiQwQ
Copy link
Contributor Author

it seems only rename for the file, let me fix it

@liangmiQwQ
Copy link
Contributor Author

now it should be right

@liangmiQwQ liangmiQwQ force-pushed the feat/add-display-chunk-details branch from 6220746 to 61d69bf Compare August 23, 2025 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants