-
-
Notifications
You must be signed in to change notification settings - Fork 49
feat: add imports display in chunk details #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
liangmiQwQ
wants to merge
12
commits into
vitejs:main
Choose a base branch
from
liangmiQwQ:feat/add-display-chunk-details
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add imports display in chunk details #82
liangmiQwQ
wants to merge
12
commits into
vitejs:main
from
liangmiQwQ:feat/add-display-chunk-details
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1b4fbee
to
3100e49
Compare
antfu
reviewed
Aug 21, 2025
it seems only rename for the file, let me fix it |
now it should be right |
Co-authored-by: Anthony Fu <[email protected]>
6220746
to
61d69bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As permalink in #12 or #9, I've done a part of the import display in chunk details.
Current Situation
i-ph-file-duotone
forimport-statement
andi-ph-lightning-duotone
fordynamic-import
showImports
in order to avoid imports displaying in assets details componentMay Need to Discuss
The imports are only for displaying so far, should we show more info about it?
Options:
In my opinion, I think maybe the first one is better?
(Note: I think the chunk displaying in assets details may also need a link)