Skip to content

do not check updatedTableInfosThisTx as we can't reset on read #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

do not check updatedTableInfosThisTx as we can't reset on read #437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions core/rs/core/src/tableinfo.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -750,11 +750,6 @@ pub extern "C" fn crsql_ensure_table_infos_are_up_to_date(
ext_data: *mut crsql_ExtData,
err: *mut *mut c_char,
) -> c_int {
let already_updated = unsafe { (*ext_data).updatedTableInfosThisTx == 1 };
if already_updated {
return ResultCode::OK as c_int;
}

let schema_changed =
unsafe { crsql_fetchPragmaSchemaVersion(db, ext_data, TABLE_INFO_SCHEMA_VERSION) };

Expand All @@ -769,9 +764,6 @@ pub extern "C" fn crsql_ensure_table_infos_are_up_to_date(
Ok(new_table_infos) => {
*table_infos = new_table_infos;
forget(table_infos);
unsafe {
(*ext_data).updatedTableInfosThisTx = 1;
}
return ResultCode::OK as c_int;
}
Err(e) => {
Expand All @@ -782,9 +774,6 @@ pub extern "C" fn crsql_ensure_table_infos_are_up_to_date(
}

forget(table_infos);
unsafe {
(*ext_data).updatedTableInfosThisTx = 1;
}
return ResultCode::OK as c_int;
}

Expand Down
2 changes: 0 additions & 2 deletions core/src/crsqlite.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ static int commitHook(void *pUserData) {
pExtData->dbVersion = pExtData->pendingDbVersion;
pExtData->pendingDbVersion = -1;
pExtData->seq = 0;
pExtData->updatedTableInfosThisTx = 0;
return SQLITE_OK;
}

Expand All @@ -47,7 +46,6 @@ static void rollbackHook(void *pUserData) {

pExtData->pendingDbVersion = -1;
pExtData->seq = 0;
pExtData->updatedTableInfosThisTx = 0;
}

#ifdef LIBSQL
Expand Down