-
Notifications
You must be signed in to change notification settings - Fork 74
Add trust remote code for Kimi-K2-Thinking #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add trust remote code for Kimi-K2-Thinking Signed-off-by: Mohammad Miadh Angkad <[email protected]>
Summary of ChangesHello @mmangkad, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the documentation for serving the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly adds the --trust-remote-code flag to the vllm serve example commands in the documentation for the Kimi-K2-Thinking model, which is a necessary change. The change also adds a newline at the end of the file, which is good practice. My review includes one suggestion to improve the documentation by adding a note about the security implications of using the --trust-remote-code flag.
|
|
||
| ```bash | ||
| vllm serve moonshotai/Kimi-K2-Thinking \ | ||
| --trust-remote-code \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While adding --trust-remote-code is necessary for this model to run, it's good practice to also inform users about the security implications of this flag. It allows arbitrary code execution from the model's repository. Consider adding a brief note in the documentation (for both this command and the one in the 'DCP Usage' section) to advise users to only use this flag if they trust the model's source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
Add trust remote code for Kimi-K2-Thinking
cc @jeejeelee