asn_internal: Call va_end before returning #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I do not know the project's code-style, in some C projects this kind of error-handling would incorporate a goto.
|
|
mouse07410
added a commit
to mouse07410/asn1c
that referenced
this pull request
Dec 26, 2023
This is vlm#401 from vlm/asn1c by @Inksz. From his PR: I do not know the project's code-style, in some C projects this kind of error-handling would incorporate a goto. But because of the general avoidance of goto I added va_end before each return. I suppose has more insight into what this function does, one could "dry" the error handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not know the project's code-style, in some C projects this kind of error-handling would incorporate a goto.
But because of the general avoidance of goto I added
va_endbefore each return.I suppose has more insight into what this function does, one could "dry" the error handling.