refactor post-selection-ui to work with wp3.5-wp4.0 #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…& gracefully degrade
johnciacia
suggested changes
May 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wpWidgets.appendTitleandwpWidgets.saveto hookinitPostSelectionUIOnEventfor all use cases for WordPress 3.5 - 4.0 (including 1. on page load, 2. adding a brand new widget when none exist yet and 3. when saving and re-rendering of post-selection-uielseconditional. @jeffstieler one thing to note on this is that these event bindings are not necessary to get this to work in WP 3.5 - 4.0, but I would venture to guess this would help future compatibility (so long as the event emitters remain as is). Could you think of any reason why these would hurt to leave them in?