[feature] add retryPolicy to JobFlow API
#191
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @mahdikhashan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new retryPolicy mechanism to the JobFlow API, significantly enhancing the resilience and error handling capabilities of job execution. This feature allows users to specify retry behaviors at both the overall job flow level and for individual flows, ensuring that transient failures can be managed effectively. The changes include the addition of new API fields and supporting data structures to define retry strategies and backoff policies, along with updates to job status for better failure diagnostics.
Highlights
- JobFlow-level Retry Policy: A
retryPolicyfield has been added to theJobFlowSpec, allowing users to define global retry configurations for an entire job flow. - Flow-level Retry Policy: A
retryPolicyfield has been introduced within theFlowstruct, enabling more granular retry settings for individual flows within a job flow. - New Retry Mechanism Structures: New Go types (
RetryPolicy,RetryStrategy,BackoffPolicy,BackoffType) have been defined to encapsulate comprehensive retry logic, including maximum retries, various retry strategies (Always, OnFailure, Never), and different backoff mechanisms (Constant, Exponential). - Job Status Enhancements: The
JobStatusstruct has been enhanced with new fields,RetryCountandLastFailureReason, to provide better visibility into job execution and aid in diagnosing failures.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a retryPolicy to the JobFlow API, a useful feature for building resilient workflows. The API changes themselves look reasonable. However, the pull request is missing the updated autogenerated code for deepcopy and applyconfiguration, which is a critical omission that will cause runtime errors. I've added a comment highlighting this and a suggestion to improve the clarity of one of the new enum values.
|
cc: @Monokaix |
part of volcano-sh/volcano#4275
implements volcano-sh/volcano#4567