Skip to content

Avoid creating staging buffers in TransferTask that exceed the Vulkan physical device property limit #1473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Avoid creating staging buffers in TransferTask that exceed the Vulkan physical device property limit #1473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e41cc5b
Avoid creating staging buffers in TransferTask that exceed the Vulkan…
May 21, 2025
afad7df
Lambda name and comment clarification.
May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions include/vsg/app/TransferTask.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@ namespace vsg
/// minimum size to use when allocating staging buffers.
VkDeviceSize minimumStagingBufferSize = 16 * 1024 * 1024;

// allocation chunk size
VkDeviceSize stagingBufferSizeChunkSize = 64 * 1024;

/// hook for assigning Instrumentation to enable profiling of record traversal.
ref_ptr<Instrumentation> instrumentation;

Expand All @@ -78,8 +81,9 @@ namespace vsg
{
ref_ptr<CommandBuffer> transferCommandBuffer;
ref_ptr<Fence> fence;
ref_ptr<Buffer> staging;
void* buffer_data = nullptr;
std::vector<ref_ptr<Buffer>> stagingBuffers;
std::vector<std::vector<VkDeviceSize>> stagingOffsets;
std::vector<void*> buffer_data;
std::vector<VkBufferCopy> copyRegions;
bool waitOnFence = false;
};
Expand All @@ -94,8 +98,6 @@ namespace vsg
std::vector<ref_ptr<TransferBlock>> frames;

VkDeviceSize dataTotalRegions = 0;
VkDeviceSize dataTotalSize = 0;
VkDeviceSize imageTotalSize = 0;

ref_ptr<Semaphore> transferCompleteSemaphore;
ref_ptr<Semaphore> transferConsumerCompletedSemaphore;
Expand All @@ -111,10 +113,10 @@ namespace vsg

TransferResult _transferData(DataToCopy& dataToCopy);

void _transferBufferInfos(DataToCopy& dataToCopy, VkCommandBuffer vk_commandBuffer, TransferBlock& frame, VkDeviceSize& offset);
void _transferBufferInfos(DataToCopy& dataToCopy, VkCommandBuffer vk_commandBuffer, TransferBlock& frame, size_t stagingBufferOffsetBegin, size_t regionOffsetBegin);

void _transferImageInfos(DataToCopy& dataToCopy, VkCommandBuffer vk_commandBuffer, TransferBlock& frame, VkDeviceSize& offset);
void _transferImageInfo(VkCommandBuffer vk_commandBuffer, TransferBlock& frame, VkDeviceSize& offset, ImageInfo& imageInfo);
void _transferImageInfos(DataToCopy& dataToCopy, VkCommandBuffer vk_commandBuffer, TransferBlock& frame, size_t stagingBufferOffsetBegin, size_t regionOffsetBegin);
void _transferImageInfo(VkCommandBuffer vk_commandBuffer, TransferBlock& frame, size_t stagingBufferOffset, size_t regionOffset, ImageInfo& imageInfo);
};
VSG_type_name(vsg::TransferTask);

Expand Down
Loading
Loading