Skip to content

[FIXED] TransferTask semaphore wait stages #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2023
Merged

[FIXED] TransferTask semaphore wait stages #968

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/vsg/app/TransferTask.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ VkResult TransferTask::transferDynamicData()

if (!semaphore)
{
semaphore = Semaphore::create(device, VK_PIPELINE_STAGE_TRANSFER_BIT);
semaphore = Semaphore::create(device, VK_PIPELINE_STAGE_ALL_COMMANDS_BIT);
}

VkResult result = VK_SUCCESS;
Expand Down Expand Up @@ -395,7 +395,7 @@ VkResult TransferTask::transferDynamicData()

vkEndCommandBuffer(vk_commandBuffer);

// if no regions to copy have been found then commandBuffer will be empty so no need to submit it to queue and use the associated single semaphore
// if no regions to copy have been found then commandBuffer will be empty so no need to submit it to queue and signal the associated semaphore
if (offset > 0)
{
// submit the transfer commands
Expand Down