op-mode: T6857: Fix default action for prerouting hook

[l0crian1]

Change summary

The firewall op-mode output for the prerouting chain has some cosmetic bugs related to the default-action. If there is no default-action set for prerouting raw, then the show firewall ipv4 prerouting raw shows the wrong verdict for the output:

Nftables output (verdict is actually accept as expected):

table ip vyos_filter {
        chain VYOS_PREROUTING_raw {
                type filter hook prerouting priority raw; policy accept;
                counter packets 191 bytes 13038 accept comment "ipv4-PRE-raw-10"
                counter packets 0 bytes 0 accept comment "PRE-raw default-action accept"
        }
}

show firewall ipv4 prerouting raw:

Ruleset Information

---------------------------------
ipv4 Firewall "prerouting raw"

Rule     Action    Protocol      Packets    Bytes  Conditions
-------  --------  ----------  ---------  -------  ------------
10       accept    all               192    12262  accept
default  drop      all                 0        0

show firewall statistics (no default-action listed):

Rulesets Statistics

---------------------------------
ipv4 Firewall "prerouting raw"

  Rule    Packets    Bytes  Action    Source    Destination    Inbound-Interface    Outbound-interface
------  ---------  -------  --------  --------  -------------  -------------------  --------------------
    10        286    17769  accept    any       any            any                  any

After changes:

show firewall ipv4 prerouting raw:

Ruleset Information

---------------------------------
ipv4 Firewall "prerouting raw"

Rule     Action    Protocol      Packets    Bytes  Conditions
-------  --------  ----------  ---------  -------  ------------
10       accept    all                83     5259  accept
default  accept    all                 0        0

show firewall statistics:

Rulesets Statistics

---------------------------------
ipv4 Firewall "prerouting raw"

Rule       Packets    Bytes  Action    Source    Destination    Inbound-Interface    Outbound-interface
-------  ---------  -------  --------  --------  -------------  -------------------  --------------------
10             144     9254  accept    any       any            any                  any
default          0        0  accept    any       any            any                  any

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
• Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• I have run the components SMOKETESTS if applicable
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly

[github-actions]

👍
No issues in PR Title / Commit Title

[github-actions]

CI integration 👍 passed!

Details

CI logs

• CLI Smoketests (no interfaces) 👍 passed
• CLI Smoketests VPP 👍 passed
• CLI Smoketests (interfaces only) 👍 passed
• Config tests 👍 passed
• Config tests VPP 👍 passed
• RAID1 tests 👍 passed
• TPM tests 👍 passed

[c-po]

Change in op-mode handling looks reasonable. Fix display output of command

[sarthurdev]

Show default action on prerouting hooks