Skip to content

Conversation

sarthurdev
Copy link
Member

@sarthurdev sarthurdev commented Sep 17, 2025

Change summary

Update to use nose2 for unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Sep 17, 2025

👍
No issues in PR Title / Commit Title

Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python3-nose is no longer shipped in Debian Trixie. python3-nose2 is backward-compatible and does exist in Debian Bookworm already, so I think we should indeed update to it to make our life simpler in the future.

The companion PR in vyos-build is now merged. I only have a simple question about whitespace change.

Copy link
Member

@c-po c-po left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to a new backwards compatible version python3-nose2. Added circinus backport label to make our code more maintainable in the future when backporting other stuff

@c-po c-po added the bp/circinus Create automatic backport for circinus label Sep 18, 2025
@sarthurdev sarthurdev merged commit 9491257 into vyos:current Sep 18, 2025
16 of 17 checks passed
Copy link

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests VPP ❌ failed
  • CLI Smoketests (interfaces only) ❌ failed
  • Config tests ❌ failed
  • Config tests VPP ❌ failed
  • RAID1 tests ❌ failed
  • TPM tests ❌ failed

@vyosbot vyosbot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bp/circinus Create automatic backport for circinus current mirror-completed
Development

Successfully merging this pull request may close these issues.

4 participants