- 
                Notifications
    You must be signed in to change notification settings 
- Fork 391
T7965: reapply the QoS policy when the interface reconnect #4816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: current
Are you sure you want to change the base?
Conversation
| 👍 | 
| All contributors have signed the CLA  ✍️ ✅ | 
| I have read the CLA Document and I hereby sign the CLA | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File is named 99-vyos-ppp-qos and thus executed prior to 99-vyos-pppoe-callback - please rename it to 99-vyos-pppoe-qos
| @c-po I have renamed the file name | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed the file permissions to be executable.
Call QoS CLI helper script when PPPoE interface reconnected and QoS was configured on interface.
| CI integration 👍 passed! Details
 | 
Change summary
pppoe interfaces may lose QoS config on reconnect. This PR reapplies the QoS policy when the interface comes up.
Types of changes
Related Task(s)
https://vyos.dev/T7965
Related PR(s)
How to test / Smoketest result
After the server-side disconnection,and when the pppoe0 link is up:
Checklist: