Skip to content

Conversation

@opswill
Copy link
Contributor

@opswill opswill commented Oct 29, 2025

Change summary

pppoe interfaces may lose QoS config on reconnect. This PR reapplies the QoS policy when the interface comes up.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T7965

Related PR(s)

How to test / Smoketest result

After the server-side disconnection,and when the pppoe0 link is up:

vyos@vyos:/etc/ppp/ip-up.d$ show qos cake interface pppoe0
qdisc cake 1: root refcnt 2 bandwidth 60Mbit diffserv3 flows nat nowash no-ack-filter split-gso rtt 100ms raw overhead 0
 Sent 666822251 bytes 3329477 pkt (dropped 16, overlimits 396425 requeues 0)
 backlog 0b 0p requeues 0
 memory used: 474624b of 4Mb
 capacity estimate: 60Mbit
 min/max network layer size:           29 /    1480
 min/max overhead-adjusted size:       29 /    1480
 average network hdr offset:            0

                   Bulk  Best Effort        Voice
  thresh       3750Kbit       60Mbit       15Mbit
  target            5ms          5ms          5ms
  interval        100ms        100ms        100ms
  pk_delay          0us        162us         10us
  av_delay          0us         15us          3us
  sp_delay          0us          1us          2us
  backlog            0b           0b           0b
  pkts                0      3326153         3340
  bytes               0    666668856       173760
  way_inds            0       247740            0
  way_miss            0       179041            7
  way_cols            0            0            0
  drops               0           16            0
  marks               0            0            0
  ack_drop            0            0            0
  sp_flows            0            3            0
  bk_flows            0            1            0
  un_flows            0            0            0
  max_len             0        21600           60
  quantum           300         1514          457

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@github-actions
Copy link

github-actions bot commented Oct 29, 2025

👍
No issues in PR Title / Commit Title

@github-actions
Copy link

github-actions bot commented Oct 29, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@opswill
Copy link
Contributor Author

opswill commented Oct 29, 2025

I have read the CLA Document and I hereby sign the CLA

vyosbot added a commit to vyos/vyos-cla-signatures that referenced this pull request Oct 29, 2025
Copy link
Member

@c-po c-po left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File is named 99-vyos-ppp-qos and thus executed prior to 99-vyos-pppoe-callback - please rename it to 99-vyos-pppoe-qos

@opswill
Copy link
Contributor Author

opswill commented Oct 29, 2025

@c-po I have renamed the file name

Copy link
Member

@c-po c-po left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the file permissions to be executable.

Call QoS CLI helper script when PPPoE interface reconnected and QoS was configured on interface.

@c-po c-po added bp/sagitta Create automatic backport for sagitta LTS version bp/circinus Create automatic backport for circinus labels Oct 29, 2025
@github-actions
Copy link

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests VPP 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • Config tests VPP 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bp/circinus Create automatic backport for circinus bp/sagitta Create automatic backport for sagitta LTS version current

Development

Successfully merging this pull request may close these issues.

2 participants