T7621 fix - re-submit logic

[omnom62]

Change Summary

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
• Other (please describe):

Related Task(s)

https://vyos.dev/T7621

Related PR(s)

Component(s) name

Proposed changes

How to test

Test results

• Sanity tests passed
• Unit tests passed

Tested against VyOS versions:

• 1.3.8
• 1.4.2
• 1.5-stream-2025-Q1

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• I have run the ansible sanity and unit tests
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly
• I have added unit tests to cover my changes
• I have added a file to changelogs/fragments to describe the changes

[omnom62]

I have read the CLA Document and I hereby sign the CLA

[dmbaturin]

Looks fine to me. @gaige, what's your opinion?

[gaige]

This is a significant change in behavior. We should document clearly and probably shouldn’t do this on less than a major release due to the non-backwards-compatible behavior.

I’m dubious of the categorization as “bug fix”, was the previous behavior out of line with the documentation or the previous functionality?

if the functionality is still wrong, we need a lot more documentation on how the current behavior is not expected and possibly a strong warning in the runtime.

if we just don’t think the default makes sense any longer, that’s a breaking change that we likely should hold for a major, since existing scripts that we’re working will break which is basically only allowed at a major release.

[omnom62]

This is a significant change in behavior. We should document clearly and probably shouldn’t do this on less than a major release due to the non-backwards-compatible behavior.

I’m dubious of the categorization as “bug fix”, was the previous behavior out of line with the documentation or the previous functionality?

if the functionality is still wrong, we need a lot more documentation on how the current behavior is not expected and possibly a strong warning in the runtime.

if we just don’t think the default makes sense any longer, that’s a breaking change that we likely should hold for a major, since existing scripts that we’re working will break which is basically only allowed at a major release.

I thought this is what we discussed.
Anyway, I feel we need to put an extra effort to make sure the commands are not skipped, some how - I will be revisiting this job in order to cover some edge uses cases like this one.

[gaige]

@omnom62 did you run tests against 1.3.8? For 6.x, we need to still ensure these. If you did, please update the PR text. If not, please do.

[omnom62]

@omnom62 did you run tests against 1.3.8? For 6.x, we need to still ensure these. If you did, please update the PR text. If not, please do.

Re-tested and updated the PR doc

[omnom62]

I added unit tests specifically to test this 'resubmit'
Also, I need to check your opinion on necessity of this

vyos.vyos/plugins/cliconf/vyos.py

Line 257 in 1070cd0

running_commands = [str(c).replace("'", "") for c in running.splitlines()]