Skip to content

Update editors & codeowners #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Update editors & codeowners #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cec731
update editors to include mahmoud
mkhraisha Jan 29, 2025
ea5e379
update codeowners
mkhraisha Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
# the repo. Unless a later match takes precedence,
# they will be requested for review when someone opens a
# pull request.
* @decentralgabe @andresuribe87
* @mkhraisha

# See CODEOWNERS syntax here: https://help.github.com/articles/about-codeowners/#codeowners-syntax
6 changes: 6 additions & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,12 @@
company: "Block",
companyURL: "https://www.tbd.website",
w3cid: 140850
Comment on lines 46 to 48
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't suggest a proper change here, due to limits in the GitHub interface, but in English — The former editors should be put into a new former-editors (or possibly added to the authors) section, distinct from the editors.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, thanks for spotting this.

There is already a "former editors" section (with Orie); I guess simply listing Gabe and the others there is the way to go.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, let's add Mahmoud as an editor and leave it at that.
As the bulk of the work on this spec was done by Gabe and Andres, I do not feel it inappropriate to continue to recognize them, but if folks want to discuss moving names to the "former editors" that should be brought up in a separate issue.

}, {
name: 'Mahmoud Alkhraishi',
url: 'https://github.com/mkhraisha',
company: 'Mavennet',
companyURL: 'https://www.mavennet.com/',
w3cid: 121911
}],
authors: [{
name: "Gabe Cohen",
Expand Down