Skip to content

Make completion cancellable and handle REPL keywords #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Make completion cancellable and handle REPL keywords #403

wants to merge 4 commits into from

Conversation

Rekkonnect
Copy link
Collaborator

  • RoslynServices.CompleteAsync can be cancelled with CancellationToken, as provided by GetCompletionItemsAsync
  • REPL command keywords (help, exit, clear)
    • Highlight them in the prompt to show that they will be executed, matching the behavior of the command handler
    • Show them as completion items

@Rekkonnect Rekkonnect requested a review from waf July 1, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waf waf waf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rekkonnect @waf