Skip to content

Conversation

@shayneo
Copy link

@shayneo shayneo commented Jul 13, 2025

Description

Updates vue template frontend dependencies

Fixes # (issue)

Type of change

Dependency bump

Please select the option that is relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration using wails doctor.

  • Windows
  • macOS
  • Linux

If you checked Linux, please specify the distro and version.

Test Configuration

# Build Environment

┌────────────────────────────────┐
| Wails CLI    | v3.0.0-alpha.11 |
| Go Version   | go1.24.1        |
| -buildmode   | exe             |
| -compiler    | gc              |
| CGO_CFLAGS   |                 |
| CGO_CPPFLAGS |                 |
| CGO_CXXFLAGS |                 |
| CGO_ENABLED  | 1               |
| CGO_LDFLAGS  |                 |
| GOARCH       | arm64           |
| GOARM64      | v8.0            |
| GOOS         | darwin          |
└────────────────────────────────┘

# Dependencies

┌───────────────────────────┐
| *NSIS           | v3.11   |
| Xcode cli tools | 2409    |
| npm             | 10.8.2  |
|                           |
└─ * - Optional Dependency ─┘

# Checking for issues

 SUCCESS  No issues found

# Diagnosis

 SUCCESS  Your system is ready for Wails development!

Checklist:

  • I have updated website/src/pages/changelog.mdx with details of this PR
  • My code follows the general coding style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Summary by CodeRabbit

  • Chores
    • Updated Vue, Vite, TypeScript, and related plugin dependencies to their latest major versions in both Vue and Vue TypeScript frontend templates.
    • Added minimum required versions for Node.js and npm in the Vue TypeScript frontend template.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 13, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 13, 2025

Walkthrough

The dependency versions in the package.json files for both the Vue and Vue TypeScript frontend templates were updated. This includes major upgrades to Vue, Vite, and related development dependencies. Additionally, an engines field specifying minimum Node.js and npm versions was added to the Vue TypeScript template. No changes were made to scripts or exported entities.

Changes

Files Change Summary
v3/internal/templates/vue-ts/frontend/package.json Upgraded Vue, Vite, TypeScript, vue-tsc, and plugin versions; added engines field for Node.js and npm minimum versions.
v3/internal/templates/vue/frontend/package.json Upgraded Vue, Vite, and plugin versions; no other changes.

Suggested labels

Enhancement, size:XS, lgtm

Suggested reviewers

  • leaanthony

Poem

A hop, a skip, a version bump—
Vue and Vite now thumpity-thump!
Dependencies fresh as morning dew,
TypeScript and plugins, all shiny and new.
The garden’s code is up to date—
Bugs beware, you’ll have to wait!
🐇✨


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between af99d23 and 7b53421.

📒 Files selected for processing (1)
  • v3/internal/templates/vue-ts/frontend/package.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • v3/internal/templates/vue-ts/frontend/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: semgrep-cloud-platform/scan

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dosubot dosubot bot added dependencies Pull requests that update a dependency file MacOS labels Jul 13, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fb8f12a and af99d23.

📒 Files selected for processing (2)
  • v3/internal/templates/vue-ts/frontend/package.json (1 hunks)
  • v3/internal/templates/vue/frontend/package.json (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
v3/internal/templates/vue-ts/frontend/package.json (1)
Learnt from: fbbdev
PR: wailsapp/wails#4001
File: v3/internal/generator/testdata/output/lang=TS/UseInterfaces=true/UseNames=false/github.com/wailsapp/wails/v3/internal/generator/testcases/function_single_internal/greetservice.ts:0-0
Timestamp: 2025-01-15T22:33:30.639Z
Learning: In the Wails framework's TypeScript bindings, the import path "/wails/runtime.js" is intentionally absolute and should not be changed to a relative path.
v3/internal/templates/vue/frontend/package.json (1)
Learnt from: fbbdev
PR: wailsapp/wails#4001
File: v3/internal/generator/testdata/output/lang=TS/UseInterfaces=true/UseNames=false/github.com/wailsapp/wails/v3/internal/generator/testcases/function_single_internal/greetservice.ts:0-0
Timestamp: 2025-01-15T22:33:30.639Z
Learning: In the Wails framework's TypeScript bindings, the import path "/wails/runtime.js" is intentionally absolute and should not be changed to a relative path.
🔇 Additional comments (2)
v3/internal/templates/vue-ts/frontend/package.json (1)

12-15: Double-check Vue 3.5.x compatibility with Wails runtime

Jumping from 3.2.x → 3.5.x is a sizable leap (multiple minor releases).
Please confirm that:

  1. The Wails bridge (@wailsio/runtime) still functions with Vue 3.5 APIs (no breaking changes in reactivity/SSR APIs you rely on).
  2. Any custom code in src/main.ts that relied on removed deprecations has been updated.

Small local builds can pass yet runtime integration may surface edge cases.
Consider at least smoke-testing a freshly generated app under Windows & Linux before merging.

v3/internal/templates/vue/frontend/package.json (1)

12-15: Verify runtime behaviour after Vue core bump

Same caution as the TS template: upgrade from 3.2.x → 3.5.x may surface subtle breaking changes (e.g. isCustomElement config defaults, SFC macro tweaks).

Run npm run dev & npm run build on a clean template, then launch with wails dev to ensure no runtime regressions.

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@sonarqubecloud
Copy link

@leaanthony
Copy link
Member

Thanks for this. I'm keen to upgrade vite across all templates. If you're willing to do that - awesome. If you don't have time then that's fine, let's turn this into an issue and we can add it to the backlog 👍

@leaanthony
Copy link
Member

Thanks 🙏 Please could you add an entry to the changelog located at v3/UNRELEASED_CHANGELOG.md? Thanks!

@shayneo
Copy link
Author

shayneo commented Sep 24, 2025

Thanks for this. I'm keen to upgrade vite across all templates. If you're willing to do that - awesome. If you don't have time then that's fine, let's turn this into an issue and we can add it to the backlog 👍

I agree with this approach 😄

Give me another week or so to see if I find a moment to knock it out, otherwise I can close this PR and create an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file MacOS size:S This PR changes 10-29 lines, ignoring generated files. templates v3-alpha

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants