Skip to content

Conversation

samumbach
Copy link
Contributor

Great, simple project! Looking forward to using this -- I'd settled on aero for Clojure configs, but the Docker secrets support in dyn-edn is a real selling point 😀 👍

Thanks!

@hlship hlship merged commit 8d880f3 into walmartlabs:master Jun 8, 2025
@samumbach samumbach deleted the improve-readme branch June 8, 2025 19:09
@samumbach
Copy link
Contributor Author

samumbach commented Jun 8, 2025

Thanks, @hlship 😁

I have a couple other changes in the works; I'll open PRs for these over the next few days:

  • Add a test demonstrating the relative priority of the property sources (I think Docker secrets may take precedence over environment variables, which is counter to the statement in the README).
  • Rename test namespaces to have -test suffix (to make it easier to run them with cognitect-labs and kaocha test runners).
  • Update implementation so tests pass when temp directory path includes a symlink (this is the default on macOS).
  • (Maybe) Add GitHub Actions for automated tests.

Please let me know if you have any immediate thoughts on these topics -- if any of these are unlikely to be merged, I'll be sure to focus my efforts on the others first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants