Skip to content

[fix] 修复StickyWMStickyPageController 偶现滚动不了bug #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[fix] 修复StickyWMStickyPageController 偶现滚动不了bug #643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eae8997
[fix] 修复StickyWMStickyPageController 偶现滚动不了bug
Dec 29, 2020
c30879c
[fix] 修复同一个item可选中多次
Apr 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion WMPageController/WMMenuView/WMMenuView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,7 +580,9 @@ - (void)addProgressViewWithFrame:(CGRect)frame isTriangle:(BOOL)isTriangle hasBo

#pragma mark - Menu item delegate
- (void)didPressedMenuItem:(WMMenuItem *)menuItem {

if (self.selItem == menuItem) {
return;
}
if ([self.delegate respondsToSelector:@selector(menuView:shouldSelesctedIndex:)]) {
BOOL should = [self.delegate menuView:self shouldSelesctedIndex:menuItem.tag - WMMENUITEM_TAG_OFFSET];
if (!should) {
Expand Down
3 changes: 3 additions & 0 deletions WMPageControllerDemo/StickyExample/StickyExample/WMStickyPageController/WMMagicScrollView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,10 @@ - (void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(N

if (diff == 0.0 || !_isObserving) return;

static CGFloat onePixel = 1/[UIScreen mainScreen].scale;
CGFloat maximumContentOffsetY = _maximumHeaderViewHeight - _minimumHeaderViewHeight;
maximumContentOffsetY = roundf(maximumContentOffsetY / onePixel) * onePixel;

if (object == self) {
//Adjust self scroll offset when scroll down
if (diff > 0 && _lock) {
Expand Down