Skip to content

Conversation

@abharkhalif711-hue
Copy link

  • [ x ] I'm the package's author and/or maintainer.
  • [ x ] I have have read the docs.
  • [ x ] I have tagged a release with a semver version number.
  • [ x ] My package repo has a description and a README describing what it's for and how to use it.
  • [ x ] My package doesn't add context menu entries. *
  • [ x ] My package doesn't add key bindings. **
  • [ ] Any commands are available via the command palette.
  • [ ] Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • [ x ] If my package is a syntax it doesn't also add a color scheme. ***
  • [ x ] I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is ...

There are no packages like it in Package Control.

My package is similar to ... However it should still be added because ...

Comment on lines +6125 to +6127
"name": "superclouds",
"details": "https://github.com/abharkhalif711-hue/supercloud-dark-theme",
"description": "a supercloud is soft dark theme",
Copy link
Collaborator

@braver braver Sep 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor changes are needed:

instead of adding your entry to the end, add it in chronological order around line 5337.

Instead of adding a description here, add a description on your GitHub repo:

Image

Your readme refers to it as "Supercloud", ie. singular and capitalized, so match there here as well.

Suggested change
"name": "superclouds",
"details": "https://github.com/abharkhalif711-hue/supercloud-dark-theme",
"description": "a supercloud is soft dark theme",
"name": "Supercloud",
"details": "https://github.com/abharkhalif711-hue/supercloud-dark-theme",

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok,

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know when you've been able to handle the feedback, or if you need any help.

@braver braver added the feedback provided The changes and package have been seen by a reviewer label Sep 13, 2025
@braver braver added the stale The author has not responded for at least 2 weeks label Oct 5, 2025
@braver braver closed this Oct 25, 2025
@braver
Copy link
Collaborator

braver commented Oct 25, 2025

Let me know if you want to restart the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feedback provided The changes and package have been seen by a reviewer stale The author has not responded for at least 2 weeks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants