-
Notifications
You must be signed in to change notification settings - Fork 96
upgrade url update #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
upgrade url update #219
Conversation
WalkthroughThe destination URL for the upgrade button in the ProPreviews component was updated to direct users to a specific pricing page with UTM parameters for marketing tracking. No other code, logic, or styling changes were made. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
| target='_blank' | ||
| href='//wedocs.co/' | ||
| href='//wedocs.co/pricing/?utm_source=wordpress-dashboard+&utm_medium=update_to_pro_pop-up&utm_campaign=free2pro_pop-up' | ||
| onClick={ showPopup } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add https:// scheme and rel="noopener noreferrer" to harden the link
- A protocol-relative URL (
//...) can unexpectedly fall back tohttpon non-TLS pages, exposing users to MITM risks. - Opening a new tab with
target="_blank"withoutrel="noopener noreferrer"leaves the app vulnerable to reverse-tabnabbing.
- target='_blank'
- href='//wedocs.co/pricing/?utm_source=wordpress-dashboard+&utm_medium=update_to_pro_pop-up&utm_campaign=free2pro_pop-up'
+ target='_blank'
+ rel='noopener noreferrer'
+ href='https://wedocs.co/pricing/?utm_source=wordpress-dashboard&utm_medium=update_to_pro_pop-up&utm_campaign=free2pro_pop-up'📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| target='_blank' | |
| href='//wedocs.co/' | |
| href='//wedocs.co/pricing/?utm_source=wordpress-dashboard+&utm_medium=update_to_pro_pop-up&utm_campaign=free2pro_pop-up' | |
| onClick={ showPopup } | |
| target='_blank' | |
| rel='noopener noreferrer' | |
| href='https://wedocs.co/pricing/?utm_source=wordpress-dashboard&utm_medium=update_to_pro_pop-up&utm_campaign=free2pro_pop-up' | |
| onClick={ showPopup } |
🧰 Tools
🪛 Biome (2.1.2)
[error] 10-10: Avoid using target="_blank" without rel="noopener" or rel="noreferrer".
Opening external links in new tabs without rel="noopener" is a security risk. See the explanation for more details.
Safe fix: Add the rel="noopener" attribute.
(lint/security/noBlankTarget)
🤖 Prompt for AI Agents
In src/components/ProPreviews/common/UpgradeButton.js around lines 10 to 12, the
href attribute uses a protocol-relative URL which can default to http and cause
security risks; update the href to include the full 'https://' scheme. Also, add
rel="noopener noreferrer" to the anchor tag to prevent reverse-tabnabbing
vulnerabilities when using target="_blank".
Summary by CodeRabbit