-
Notifications
You must be signed in to change notification settings - Fork 10
X icon and URL updated #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Tweaked with the correct X icon, as we're living in the 80s where putting X in things is cool... |
renamed Twitter to X in the feilds, and added Twitter fields (with X branded) so users who have their fields set to Twitter can't going to lose icons |
@weallwegot Any plans to get this merged? |
yow sorry for the delay, i may have missed this one! Taking a quick look now, is there a way to retain old support for the old fab icon for twitter in addition to the new X one? |
}, | ||
{ | ||
name: "Twitter", | ||
icon: "fab-x-twitter", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bluefroguk1 Maybe revert this to fab-twitter
to align with this comment. Please also add it back to settings.yml
in that case. Thanks!
Updated to reflect Space Karen's poor sense of branding