feat(ios): Add WebDriverAgent 5.x-7.x compatibility #1426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented fallback logic to support WebDriverAgent 5.x through 7.x: - tap(): Tries new endpoint (WDA 6.0+) first, falls back to legacy endpoint (WDA 5.x) - getScreenScale(): Tries /wda/screen endpoint first, calculates from screenshot if unavailable This implementation follows Python facebook-wda's compatibility approach with try-catch fallback strategy. Changes: - Enhanced tap() with dual-endpoint support (new: /wda/tap, legacy: /wda/tap/0) - Enhanced getScreenScale() with calculation fallback using screenshot dimensions - Added comprehensive unit tests covering all fallback scenarios - All comments in English for consistency 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
yuyutaotao
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add backward compatibility support for WebDriverAgent versions 5.x through 7.x in the iOS WebDriver client.
Key Changes
tap()method: Implements fallback from new endpoint (/wda/tap) to legacy endpoint (/wda/tap/0)getScreenScale()method: Implements fallback from WDA endpoint to calculation-based approach using screenshot dimensionsImplementation Details
This implementation follows the Python facebook-wda library's compatibility approach:
Compatibility Matrix
tap()/wda/tap/0/wda/tap/wda/tapgetScreenScale()/wda/screen/wda/screen/wda/screenTest Coverage
Added comprehensive unit tests in
ios-webdriver-client-compatibility.test.ts:Breaking Changes
None - This change is fully backward compatible. All existing functionality is preserved.
References
🤖 Generated with Claude Code