fix(source-map): correct sources in CSS source map #6458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
chenjiahan
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes CSS source map generation to ensure sources contain relative paths when JS source maps are disabled and CSS source maps are enabled. The fix applies the same moduleFilenameTemplate configuration used for JS source maps to CSS source maps as well.
Key Changes:
- Added
moduleFilenameTemplateconfiguration to CSS source map settings - Added test to verify CSS source map
sourcesfield contains correct relative paths
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/plugins/sourceMap.ts | Applied moduleFilenameTemplate to CSS source map configuration |
| e2e/cases/source-map/basic/index.test.ts | Added test coverage for CSS source map structure and relative path verification |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure the
sourcesare relative paths when disabling JS source maps and enabling CSS source maps.Related Links
Checklist