Skip to content

Conversation

captainbrosset
Copy link
Contributor

#1012 is not getting recognized by the web-features bot because the id XSLT is upper case. All web-features IDs are lowercase.

@foolip
Copy link
Member

foolip commented Sep 5, 2025

I edited #1012 as that was the only way to re-run the workflow. So the immediate problem is fixed.

continue;
}

const id = match[1].toLowerCase();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I"d be tempted to write a helper function rather than have to remember to write toLowerCase every time you are going to check if the feature exists, even if it's something mildly unpleasant like:

function addIfExists(feature, gatheredFeatures) {
  const id = feature.toLowerCase();
  if (features[id]) {
    gatheredFeatures.add(id);
  }
}

(mildly unpleasant because it's mutating its arguments, but I think anything nicer would end up wrapping gatheredFeatures in a class, which is probably overkill for this kind of script).

@foolip
Copy link
Member

foolip commented Oct 16, 2025

Oops, we never merged this. @captainbrosset would bad things happen if we merge this now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants